Conversation
The dollar sign was misleading especially when newbies just copy paste and find the code doesn't work in the terminal. Thus removed it.
Collaborator
|
It helps the 'newbies' develop the culture of reading error messages and debugging....that was precisely the reason the keys were also not added... But if @sigu feels its not necessary anymore we can do away with the $ too. |
Contributor
Author
|
That's good for the learners. However I recommend then at the end include something like: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dollar sign was misleading especially when newbies just copy paste and find the code doesn't work in the terminal. Thus removed it.